Skip to content

rename values for .skb.apply(how=...)#1628

Merged
rcap107 merged 6 commits into
skrub-data:mainfrom
jeromedockes:rename-how-values
Sep 23, 2025
Merged

rename values for .skb.apply(how=...)#1628
rcap107 merged 6 commits into
skrub-data:mainfrom
jeromedockes:rename-how-values

Conversation

@jeromedockes

@jeromedockes jeromedockes commented Sep 22, 2025

Copy link
Copy Markdown
Member

As discussed in 1614 , this changes the values for the how parameter of .skb.apply() to match the names of the corresponding transformers. The options are now

'auto' -> let skrub decide, the default
'cols' -> ApplyToCols
'frame' -> ApplyToFrame
'no_wrap' -> no wrapping

the behavior is unchanged, only the values change. The old values 'auto', 'columnwise', 'sub_frame', 'full_frame' are kept with a FutureWarning

@jeromedockes jeromedockes added the data_ops Something related to the skrub DataOps label Sep 22, 2025
@jeromedockes jeromedockes added this to the 0.6.2 milestone Sep 22, 2025
@rcap107 rcap107 mentioned this pull request Sep 17, 2025
Closed
6 tasks
rcap107
rcap107 reviewed Sep 23, 2025
View reviewed changes
Comment thread skrub/_data_ops/tests/test_data_ops.py
rcap107
rcap107 approved these changes Sep 23, 2025
View reviewed changes

@rcap107 rcap107 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jeromedockes

@rcap107 rcap107 merged commit d745548 into skrub-data:main Sep 23, 2025
26 checks passed
rcap107 added a commit to rcap107/skrub that referenced this pull request Sep 25, 2025
@jeromedockes @rcap107
rename values for .skb.apply(how=...) (skrub-data#1628)
743f643 
Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
rcap107 added a commit that referenced this pull request Sep 25, 2025
@jeromedockes @rcap107
rename values for .skb.apply(how=...) (#1628)
3f41fcc 
Co-authored-by: Riccardo Cappuzzo <7548232+rcap107@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcap107 rcap107 rcap107 approved these changes

Assignees

No one assigned

Labels

data_ops Something related to the skrub DataOps

Projects

None yet

Milestone

0.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jeromedockes @rcap107